Closed Mamaduka closed 2 days ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Size Change: -29 B (0%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
build/block-library/index.min.js |
221 kB | -29 B (-0.01%) |
Flaky tests detected in e090dbaee72d991256c54c678ff534364412de12. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
đ Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11930058707 đ Reported issues:
/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js
Thank you, @t-hamano!
What?
This is a follow-up to #58387.
PR removes client-side
label
attribute synchronization for the Home Link block in favor of render time default.Why?
The PHP side defaults shouldn't be preferred over the client-side synchronization for translatable strings when possible.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast