Closed im3dabasia closed 3 hours ago
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot
label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: im3dabasia <im3dabasia1@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
:wave: Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
Warning: Type of PR label mismatch
To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.
@im3dabasia Going forward with #67212 seems like the ideal solution, so let's close this PR. Thank you for your efforts!
What?
Fixes: #67152 This PR adds proper up/down arrow key navigation to the filter configuration listbox in the DataViews component. It ensures that the up and down arrows now navigate through filter options as expected.
Why?
This PR addresses an issue where the up and down arrow keys did not work as expected for navigation in the filter configuration listbox of the DataViews component. The left and right arrow keys were functioning correctly, but up and down arrows did not navigate between options. This behavior is now fixed, resolving issue [ #67152 ]
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
https://github.com/user-attachments/assets/0dbefcad-1da7-4d61-942e-0be6d7972184