Fix: Prevent block UI from showing above settings panel on mobile

sarthaknagoshe2002 commented 1 day ago

Fixes: #63845

What?

This PR addresses an issue where interacting with the block settings panel on mobile reveals the underlying UI of blocks. Specifically:

Adjusting the padding displays the blue margin indicators.
Adjusting the height of the Cover block (and similar blocks like Spacer) reveals underlying UI elements.

Why?

When interacting with the settings panel, users should only see and interact with the settings themselves. Showing the block UI underneath is confusing and can lead to unintended actions or distractions. This behavior affects usability and creates a suboptimal user experience on mobile devices.

How?

Added a media query for mobile devices to the .components-popover.block-editor-block-popover class, setting z-index: -1 when the viewport width is below $break-medium. This ensures the popover doesn't overlay or interact with elements improperly on smaller screens.

Testing Instructions

Create a new post on mobile
Adjust the padding and set the height of the cover block
The underlying UI of the block doesn't show up above the settings panel

github-actions[bot] commented 1 day ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 1 day ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sarthaknagoshe2002 <sarthaknagoshe2002@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>
Co-authored-by: mrfoxtalbot <mrfoxtalbot@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

WordPress / gutenberg