Duotone: Fix scrollbars displayed on Duotone Control

yogeshbhutkar commented 1 day ago

Fixes: #67158

What?

This PR resolves a bug in the Duotone Control that causes scrollbars to appear around it.

How?

In the previous patches, some negative margins were introduced that broke the layout inside the container and caused scrollbars to appear. It seems like these negative margins are rather a design principle in other components such as the overlay component but looks odd in Duotone. Hence, setting margin as 0 for it fixed the issue while keeping the design consistent with other menus.

Note: This happens because of a padding 0 CSS rule provided below:

&:has(.components-menu-group) {
    padding: 0;

    .components-dropdown-menu__menu > .components-menu-item__button,
    > .components-menu-item__button {
        margin: $grid-unit-10;
        width: auto;
    }
}

But, it cannot be directly removed as the styles of other components depend on this rule ( like the Dimension Menu ), and removing padding 0 from here would make styles look inconsistent there. Hence, creating a new class solely for the duotone content is justified to selectively fix the issue.

Testing Instructions

Create an image block.
Go to Styles.
Go to Duotone and open the Duotone control.

Screencast

https://github.com/user-attachments/assets/d51ddb43-9fc4-4af2-8fb0-9c84c2c52a89

github-actions[bot] commented 1 day ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 1 day ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 1 day ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 1 day ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

WordPress / gutenberg