WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Query Loop block: remove 'add new post' prompt in the sidebar #67189

Open dhruvang21 opened 1 day ago

dhruvang21 commented 1 day ago

Fixes:- https://github.com/WordPress/gutenberg/issues/67177

What?

This PR removes the "Add New Post" link in the Query Loop block's description.

Why?

The "Add New Post" link in the Query Loop block directs users to the post editor. While its intent is to guide users to create posts for an empty Query Loop block, it disrupts the user's workflow by taking them away from the editor. This leads to potential confusion as users may not know how to return and continue working on the Query Loop block. Removing the link ensures a more seamless experience.

How?

The link has been removed from the Query Loop block's description. This adjustment ensures that users are not redirected away from their current editing context.

Testing Instructions

  1. Open a post or page.
  2. Insert a query loop block.
  3. Observe that the "Add New Post" link is no longer present in the block's description.

Screenshots or screencast

image

github-actions[bot] commented 1 day ago

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] commented 1 day ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dhruvang21 <dhruvang21@git.wordpress.org>
Co-authored-by: annezazu <annezazu@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

dhruvang21 commented 1 day ago

I haven’t deleted the create-new-post-link.js file yet, as I believe removing it would require proper documentation or mentioning it in the changelog. I’m not entirely sure of the exact process, so I’d appreciate guidance from the reviewers. Once clarified, I’ll delete the file in the next commit.

annezazu commented 9 hours ago

Just tested! Works for me.