search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Navigation block: Remove more obsolete Block Hooks helpers #67193

Open ockham opened 23 hours ago

ockham commented 23 hours ago

What?

Remove a number of Block Hooks related functions from the Navigation block.

Follow-up to #64676.

Why?

As of WP 6.6, Core has replaced usage of these functions by counterparts of its own:

And per https://github.com/WordPress/gutenberg/pull/67117, 6.6 is the minimum required WordPress version for the Gutenberg plugin.

How?

By removing code.

Note

There's a companion PR in wordpress-develop to move these functions into deprecated.php: https://github.com/WordPress/wordpress-develop/pull/7849

Testing Instructions

This should be covered by unit tests (which are run both against the current and previous WP versions). In addition, you can smoke-test Block Hooks in the Navigation block as described in other related PRs, e.g. https://github.com/WordPress/gutenberg/pull/59021.

github-actions[bot] commented 22 hours ago

Flaky tests detected in e33647b55717d64495e7ade86f59087df7e7ba78. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11950108503 📝 Reported issues: