Fix ESLint Jest reporting entire body of the test function rather than the identifier

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.

https://wordpress.org/gutenberg/

Other

10.54k stars 4.21k forks source link

Fix ESLint Jest reporting entire body of the test function rather than the identifier #67222

Closed manzoorwanijk closed 3 days ago

manzoorwanijk commented 3 days ago

Fixes #67185

What?

In the previous versions, eslint-plugin-jest reported the entire body as erroneous for expect-expect rule, which adds a lot of noise as mentioned in the linked issue.

Why?

The latest version removes that noise.

How?

This PR updates eslint-plugin-jest to the latest version

Testing Instructions

Open a test file in VS Code
Remove the assertion call
Confirm that the expect-expect warning is shown on the test function identifier (test, it), rather than the whole body.

Testing Instructions for Keyboard

Screenshots or screencast

Before	After

github-actions[bot] commented 3 days ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.