search

WordPress / gutenberg

The Block Editor project for WordPress and beyond. Plugin is available from the official repository.
https://wordpress.org/gutenberg/
Other
10.53k stars 4.21k forks source link

Dashicons: Remove non-existent icons from type #67235

Open t-hamano opened 5 hours ago

t-hamano commented 5 hours ago

What?

I noticed that there were two types of dashicons included that didn't have CSS defined, so I'm going to remove them.

https://github.com/t-hamano/wordpress-develop/blob/a27e6a8ecd5279a45e47ef88d048643740d07b5a/src/wp-includes/css/dashicons.css

Why?

Because these two icon strings don't display anything.

Testing Instructions

github-actions[bot] commented 5 hours ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] commented 5 hours ago

Flaky tests detected in 79cd524c947ee29e3c5709ad724ed9b4858c9746. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11973642853 📝 Reported issues: