WordPress / meta-environment

A collection of scripts that provision the official WordPress.org websites into a Varying Vagrant Vagrants installation.
191 stars 69 forks source link

Anti-parameter expansion measures #151

Open tomjn opened 3 years ago

tomjn commented 3 years ago

A lot of the provisioners use statements such as this:

wme_clone_meta_repository $BASE_DIR

The problem here is that if $BASE_DIR contained a space, e.g. "test value" then it would expand to wme_clone_meta_repository test value not wme_clone_meta_repository "test value". This would allow additional parameters and commands to be included in unexpected places.

What Needs To Happen

Bare variables of the form $FOO need to be replaced with quoted versions e.g. "${BAR}"