WordPress.org: fix #153 - cavalcade provisioning failures

WordPress / meta-environment

A collection of scripts that provision the official WordPress.org websites into a Varying Vagrant Vagrants installation.

190 stars 69 forks source link

WordPress.org: fix #153 - cavalcade provisioning failures #158

Closed tomjn closed 3 years ago

tomjn commented 3 years ago

Refactors cavalcade provisioning to:

remove duplication
handle when the service fails to restart
better handle folder creation
avoid potential permission issues for some files
prevent parameter expansion on the changed lines that could cause sites with spaces in their folder names to fail

herregroen commented 3 years ago

Just tested this and it resolves provisioning failing when tested from a clean VVV. It does not work when testing on a VVV that previously failed provisioning, there the error fatal: destination path '/srv/www/wordpress-meta-environment/wordpressorg.test/public_html/wp-content/mu-plugins/cavalcade' already exists and is not an empty directory. occurs.

Provisioning does still show the message Failed to restart cavalcade-wordpressorg.service: Unit cavalcade-wordpressorg.service not found..

tomjn commented 3 years ago

@herregroen thanks for testing, I didn't think this would get Cavalcade operational, but I'm glad it's made progress and the error message is useful :)

herregroen commented 3 years ago

@tomjn Given this does resolve provisioning and thus leaves you with an actual working meta environment I'd be very much in favor of getting this merged even if it doesn't fully get Cavalcade operational.

Better to have a meta environment without cron jobs running than not having one at all.

tomjn commented 3 years ago

@herregroen I agree, in the meantime I just made a change to update the cavalcade plugin if it's already cloned rather than printing an error, if that's all good then I think we can merge this

psrpinto commented 3 years ago

I also tested this locally I can confirm it fixes provisioning on a clean VVV (I did not test on a VVV that previously failed provisioning).

Similarly to https://github.com/WordPress/meta-environment/pull/158#issuecomment-848911885, I too had the following printed, though the environment appears to work correctly:

Failed to restart cavalcade-wordpressorg.service: Unit cavalcade-wordpressorg.service not found..

tomjn commented 3 years ago

Then I'm going to make the executive decision to merge but keep the issue open so we can continue to look into getting cavalcade running but unblock provisioning