WordPress / meta-environment

A collection of scripts that provision the official WordPress.org websites into a Varying Vagrant Vagrants installation.
190 stars 69 forks source link

Update installation instructions in light of vvv-config.yml #82

Closed iandunn closed 7 years ago

iandunn commented 8 years ago

VVV now has a YAML config file to allow the user which default sites to provision, and it includes the Meta Environment as an option. See https://github.com/Varying-Vagrant-Vagrants/VVV/pull/319 and https://github.com/Varying-Vagrant-Vagrants/VVV/pull/980.

It's off by default, but we can update our installation instructions to ask users to just uncomment that line and re-run the provisioner.

It looks like it'll install it to the wordpress-meta-environment directory (to avoid #9), but I haven't verified that. #9 should be fixable now though, also thanks to https://github.com/Varying-Vagrant-Vagrants/VVV/pull/980.

iandunn commented 7 years ago

@LoreleiAurora mentioned an issue in the install process that we should document.

When users install the Meta Environment via the new YAML file, the process runs after the hostsupdater plugin has ran, so they won't have the hosts defined during the first vagrant {up|provision}. We should have an installation step to run vagrant reload, so that the hostnames are added.

jeremyfelt commented 7 years ago

@iandunn I think we'll have that fixed by the time 2.0.0 ships. The fewer steps the better. :)

jeremyfelt commented 7 years ago

Ok, eating my words on this a bit. I'm still getting familiar myself. :)

If the domains are in the vvv-config.yml file, no reload would be necessary. But, in the case of the meta environment, we don't want to do that by default because there's quite a few. Those should be fed from the vvv-hosts in the project (which they are). In this case, a reload is needed to trigger hostsupdater.

I'm pretty sure that another vagrant up will trigger the same thing and not require the full reload process, but we'll need to test that.

LoreleiAurora commented 7 years ago

vagrant up will do that without going through a full reload.

kevinwhoffman commented 7 years ago

I wanted to share my experience trying to set up the Meta Environment for contributing to the Plugin Directory. It touches on some of the issues described above regarding hosts.

I ran my initial vagrant up with the Meta Environment lines uncommented in vvv-config.yml. While this provisioned the Meta sites, it did not update my hosts file and therefore I could not access wp-meta.dev or any of the Meta sites. This is confusing to first-timers trying to set up the Meta Environment. I fixed it by running vagrant provision again, but it would be good to automate that if possible, or at least communicate to the developer that an additional vagrant {up|provision} is required.

ntwb commented 7 years ago

@kevinwhoffman Do have the Vagrant vagrant-hostsupdater plugin installed?

See https://github.com/WordPress/meta-environment/blob/master/docs/install.md#initial-setup

If you do, are you using Windows by any chance? I've a vague recollection that that can be troublesome on Windows