search

WordPress / openverse-api

The Openverse API allows programmatic access to search for CC-licensed and public domain digital media.
https://api.openverse.engineering/v1
MIT License
77 stars 51 forks source link

Remove resendverificationemails command and tests #1042

Closed sarayourfriend closed 1 year ago

sarayourfriend commented 1 year ago

Problem

Now that verification emails are sent and the issue is fixed, we can remove this command. Critically, we can remove it's slow-running tests.

Description

Remove the command and the associated tests. If we ever need it again for some reason we can revert the change.

Implementation

sahil-R commented 1 year ago

Hey @sarayourfriend, can i try this as well?? can you assign this to me

krysal commented 1 year ago

It's yours @sahil-R!

sahil-R commented 1 year ago

Thank you, @krysal, @sarayourfriend, @AetherUnbound and @dhruvkb How should I handle the cases when the api-test is done too frequently since the response that we get in that case is a 429? Should I assert for 429 or 200 or leave it as it is i.e. 200?

Also i have been waiting for the API to be healthy , when i do docker compose up i see that aiohttp module is not found however i have already installed it can you please also help me with this

sarayourfriend commented 1 year ago

@sahil-R For this issue you should only need to delete the resendverificationemails command and the related tests. We shouldn't have to change any tests, as far as I can think. Can you share a draft PR of what you've got going so far? It would be easier to advise if we could see the specific area you're mentioning.

Also i have been waiting for the API to be healthy , when i do docker compose up i see that aiohttp module is not found however i have already installed it can you please also help me with this

You may need to run just build web to get the dependencies re-initialised in the Django base image. Any time dependencies change it requires rebuilding the web service's image.