WordPress / openverse-api

The Openverse API allows programmatic access to search for CC-licensed and public domain digital media.
https://api.openverse.engineering/v1
MIT License
76 stars 50 forks source link

Use `GITHUB_TOKEN` to prevent rate limiting errors in `setup-just` #1054

Closed dhruvkb closed 1 year ago

dhruvkb commented 1 year ago

Description

The setup-just workflow experiences a high number of failures due to rate-limiting. This PR provides the GITHUB_TOKEN secret to the workflow to prevent these errors, as recommended in the docs.

I applied the "critical" priority to this issue because if CI fails for contributors, they have no way to re-run a failing job and must request a maintainer to re-run it on their behalf.

Checklist

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
github-actions[bot] commented 1 year ago

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1054

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

krysal commented 1 year ago

I added the token in PR #1013 @dhruvkb. It just needs one more review. Could you look at it? 🙂 I don't want it to diverge from the main branch anymore.

dhruvkb commented 1 year ago

@krysal approved! I'll close this PR then.

krysal commented 1 year ago

Thanks! Done ✅