Closed dhruvkb closed 1 year ago
Storybook and Tailwind configuration previews: Ready
Storybook: https://wordpress.github.io/openverse-frontend/_preview/2149 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2149/tailwind
Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.
You can check the GitHub pages deployment action list to see the current status of the deployments.
Size Change: -4.97 kB (-1%)
Total Size: 894 kB
Filename | Size | Change | |
---|---|---|---|
./.nuxt/dist/client/223.js |
0 B | -272 B (removed) | đ |
./.nuxt/dist/client/223.modern.js |
0 B | -276 B (removed) | đ |
./.nuxt/dist/client/224.js |
0 B | -1.85 kB (removed) | đ |
./.nuxt/dist/client/app.js |
146 kB | -2.35 kB (-2%) | |
./.nuxt/dist/client/app.modern.js |
120 kB | -2.43 kB (-2%) | |
./.nuxt/dist/client/runtime.js |
2.59 kB | -89 B (-3%) | |
./.nuxt/dist/client/runtime.modern.js |
2.59 kB | -88 B (-3%) | |
./.nuxt/dist/client/204.js |
271 B | +271 B (new file) | đ |
./.nuxt/dist/client/204.modern.js |
276 B | +276 B (new file) | đ |
./.nuxt/dist/client/205.js |
1.85 kB | +1.85 kB (new file) | đ |
This component would look great if it changes to Link's Figma component. The style is almost the same, and it adds consistency to the upcoming style revisit goal.
I hope it stays within the same purpose of this PR.
@panchovm we could make it look like a Link but since it is a functionally a Button, some of the interactions would be different. For example, if you hover over a link, it might change text color or show an underline but the same interactions on a button would look very out of place.
Let's keep it as VButton then. I am currently working on a design proposal for improving the VButton style across the site and Figma documentation. So leveraging this and other similar cases in the idea I am handling.
Thanks @dhruvkb.
In that case, I'll undraft this so that can can patch the bug and we will refine the UI with the rest of the UI refinement project that will include the refresh of the button designs.
Fixes
Fixes #2129 by @dhruvkb
Description
This PR removes the ring offset from the 'Clear filters' button because that causes the ring to appear thicker. Now the thickness of the focus ring is consistent with the rest of the app.
Testing Instructions
Screenshots
https://user-images.githubusercontent.com/16580576/217169268-b7875fb7-a412-43e4-9d27-ac6aa0fb6847.mov
^ The first occurrence is the move hover and the second is the keyboard focus
Checklist
Update index.md
).main
) or a parent feature branch.[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
Developer Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```