Closed anton202 closed 1 year ago
@zackkrida @olga thank you for your comments and changes and thx for correcting my english in evrey PR :))) i`ll commit zack`s chaanges on sunday. regarding accessibility, never really addreessed accessibility stuff before. so as you mentioned, i`ll add the ability to switch the toggle button using the keyboard. regading the focus style, of course if @panchovm have an answear for it that will be great, but any way i`ll check in the design library that i took this switch toggle from (i think it was from wordpress design library)
The toggle element used in Openverse is the one from the WordPress Design Library. So please use that one and replace the focus color with openverse pink
.
I also noticed that this ticket addresses a component change. Not sure if it covers the toggle element but worth checking its scope. In any case, we need to follow the last version of WordPress' toggle component.
Fixes
Related to WordPress/openverse#636 by @panchovm
Description
This PR creates a Toggle switch and a new senesetive content filter
Checklist
Update index.md
).main
) or a parent feature branch.[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
Developer Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```