github-actions[bot]
commented
1 year ago Storybook and Tailwind configuration previews: Ready
Storybook: https://wordpress.github.io/openverse-frontend/_preview/2155 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2155/tailwind
Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.
You can check the GitHub pages deployment action list to see the current status of the deployments.
Fixes
Fixes #2150 by @obulat
Description
This is a better alternative to #2152 that uses @zackkrida's suggestion about splitting the height settings for "yellow" and "white" pages.
I previously thought that joining the layouts would give us two improvements:
However, I realized that since we used a
keyto make sure that the page is re-rendered to change the layout color, the number of re-renders would not change. Any change in color would cause the whole page to re-render. Also, the second point for setup is not as necessary. We might use the App.vue when we migrate to Nuxt 3 in future.Having two different layouts (
defaultfor "yellow" full-height pages andcontentLayoutfor the "white" scrollable pages) fixes the issues with header scrolling or the bottom of the footer being cut off.Testing Instructions
Checkout the PR and test that the height is correct on all pages, both on mobile and desktop, especially iOS.
Checklist
Update index.md).main) or a parent feature branch.[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
Developer Certificate of Origin
Developer Certificate of Origin
``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```