WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
239 stars 191 forks source link

Can't run linting locally #1099

Closed AetherUnbound closed 1 year ago

AetherUnbound commented 1 year ago

Description

When I run just lint, I receive the following error:

Skipping pre-commit installation
python3 pre-commit.pyz run  --all-files  
i18n.....................................................................Passed
Trim Trailing Whitespace.................................................Passed
Check that executables have shebangs.....................................Passed
Check JSON...............................................................Passed
Check for case conflicts.................................................Passed
Check Toml...............................................................Passed
Check for merge conflicts................................................Passed
Check Xml................................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Mixed line ending........................................................Passed
Fix python encoding pragma...............................................Passed
Check docstring is first.................................................Passed
Fix requirements.txt.................................(no files to check)Skipped
isort....................................................................Passed
pyupgrade................................................................Passed
ruff.....................................................................Passed
black....................................................................Passed
pydocstyle...............................................................Passed
eslint...................................................................Passed
prettier.................................................................Passed
ShellCheck v0.8.0........................................................Passed
types....................................................................Failed
- hook id: types
- exit code: 1

 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command failed with ENOENT: vue-tsc -p frontend --noEmit
spawn vue-tsc ENOENT

render-precommit.........................................................Passed
render-prettier..........................................................Passed
render-github............................................................Passed
render-release-drafter...................................................Passed
error: Recipe `lint` failed on line 88 with exit code 1

Here's some other system information:

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:    22.04
Codename:   jammy

$ uname -a
Linux liet-kynes 5.19.0-38-generic #39~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 17 21:16:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

$ pnpm --version
7.17.1

Additional context

This prevented my initial ability to push #1098

zackkrida commented 1 year ago

@AetherUnbound no promises, but you may need to just node-install prior to just lint. It might be that a PR introduced a new JS dependency that isn't installed yet.

AetherUnbound commented 1 year ago

That was it, thanks!