search

WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
240 stars 194 forks source link

Release drafter includes the latest changes on `main`, not the latest changes up to the passed `sha` #2175

Open zackkrida opened 1 year ago

zackkrida commented 1 year ago

I believe this setting in the release note drafter:

https://github.com/WordPress/openverse/blob/1a0c44a188a9d94af8ab19ac48d6af8ef4ee75b3/.github/workflows/release-app.yml#L108

means that the generated release notes will include all changes on main since the previous release, instead of all changes up to the provided sha.

Am I understanding this correctly, @WordPress/openverse-maintainers? I think currently, this means that deploying any sha, will show all changes including those made after the sha.

sarayourfriend commented 1 year ago

Yes, it should be updated to the SHA rather than main :+1: