search

WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
237 stars 187 forks source link

`ContentProvider.provider_identifier` and `AbstractMedia.provider` have different max lengths despite referring to the same thing #2488

Closed sarayourfriend closed 1 week ago

sarayourfriend commented 1 year ago

Description

https://github.com/WordPress/openverse/blob/098925afa90b26881b4b4d3e2baffa69049692c0/api/api/models/models.py#L23

and

https://github.com/WordPress/openverse/blob/098925afa90b26881b4b4d3e2baffa69049692c0/api/api/models/mixins.py#L103-L109

refer to the same concept but have different max lengths (50 and 80 respectively).

Additional context

cc @obulat as I think this would be something that could be considered part of the larger data normalisation work :thinking:

obulat commented 2 weeks ago

I think we should set the provider_identifier's max_length to 80.