WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
255 stars 204 forks source link

Related media heading sizes different in audio/image pages #3863

Open obulat opened 9 months ago

obulat commented 9 months ago

Problem

The Related images uses a Heading 5 for screens above md and the Related audio always uses a Heading 6. These both should probably be Heading 5 above md, @fcoveram ?

image

Additional context

First reported by @zackkrida : https://github.com/WordPress/openverse/pull/3831#discussion_r1509533709

This issue is blocked because it needs input from @fcoveram

Changes necessary

https://github.com/WordPress/openverse/blob/868d764a619c187cee1a3d841502128dc571b80c/frontend/src/components/VMediaInfo/VRelatedMedia.vue#L15-L16

Should be changed to

class="heading-6 mb-6 md:heading-5"

The visual regression test snapshots will probably need to be updated. Here's the documentation on the update procedure: https://docs.openverse.org/frontend/reference/testing_guidelines.html#debugging

fcoveram commented 8 months ago

Yes, you are right. Heading 5 for screens above md in both pages.

Mang0codes commented 1 month ago

Hi! I would like to work on this.

obulat commented 1 month ago

Hi @Mang0codes ! Please go ahead, I'm going to assign the issue to you.