search

WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
246 stars 197 forks source link

Using the "+" and "|" characters for searches doesn't change anything #456

Open obulat opened 1 year ago

obulat commented 1 year ago

Problem

On the search help, we describe the use of combining characters for a better search query.

However, using some of them does not seem to change the results. Namely, the queries such as "dog fish", "dog+fish" and "dog|fish" seem to return the same results, at least on the first page.

Description

The changes to the search results based on the query should be implemented in the API. On the frontend side, we can remove the descriptions of "+" and "|" queries until they are implemented in the API.

Alternatives

@WordPress/openverse-maintainers, do you think removing the parts about "+" and "|" queries from the frontend Search help page makes sense for now? Do you have better suggestions?

Additional context

First reported by @AetherUnbound

sarayourfriend commented 1 year ago

This seems like it is mostly an API issue, as the implementation for these features depends on the simple query string ES functionality. If we do make the modification in the frontend to remove the non-working features, we should have a complimentary issue in the API to discover and fix what the issue is causing these features not to work (maybe some kind of escaping?).

sarayourfriend commented 5 months ago

We've disabled |, and + in theory works, but is probably meaningless because we don't do a good job of handling grouping, I don't think.

https://github.com/WordPress/openverse/pull/3360/files#diff-8429482fb10e7f976ad2295c754632b960e3edc0dae9edfa29504cbabf24d967R62

@obulat do you think we can close this issue?