WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
254 stars 204 forks source link

Increase the timeout before taking a dark snapshot #5106

Closed obulat closed 3 weeks ago

obulat commented 3 weeks ago

Fixes

Fixes #5087 by @obulat

Description

This PR increases the sleep time from 100ms to 200ms to ensure that the rendering is finished before taking the dark snapshot.

Testing Instructions

The CI should pass (I will re-run the VR tests several times)

Checklist

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
github-actions[bot] commented 3 weeks ago

Latest k6 run output[^update]

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  9.1 MB/s
     data_sent......................: 837 kB  5.1 kB/s
     http_req_blocked...............: avg=26.64µs  min=1.94µs   med=3.58µs   max=9.5ms   p(90)=5.09µs   p(95)=5.47µs  
     http_req_connecting............: avg=22.37µs  min=0s       med=0s       max=9.44ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=568.8ms  min=43.75ms  med=495.9ms  max=2.47s   p(90)=1.03s    p(95)=1.13s   
       { expected_response:true }...: avg=568.8ms  min=43.75ms  med=495.9ms  max=2.47s   p(90)=1.03s    p(95)=1.13s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=135.41µs min=42.51µs  med=108.95µs max=14.48ms p(90)=174.02µs p(95)=213.09µs
     http_req_sending...............: avg=21.68µs  min=7.03µs   med=18.56µs  max=8.14ms  p(90)=24.63µs  p(95)=27.07µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=568.65ms min=43.62ms  med=495.78ms max=2.47s   p(90)=1.03s    p(95)=1.13s   
     http_reqs......................: 6400    39.029465/s
     iteration_duration.............: avg=3.04s    min=733.13ms med=2.56s    max=8.9s    p(90)=5.94s    p(95)=6.28s   
     iterations.....................: 1200    7.318025/s
     vus............................: 2       min=2       max=30
     vus_max........................: 30      min=30      max=30

[^update]: This comment will automatically update with new output each time k6 runs for this PR