WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
254 stars 203 forks source link

ETL mermaid diagram is missing link text #5147

Open AetherUnbound opened 1 week ago

AetherUnbound commented 1 week ago

Description

The ETL documentation page is missing a link: https://docs.openverse.org/meta/media_properties/etls.html

Clicking on the box does jump to the appropriate session, but we should figure out why the text isn't rendering.

Screenshots

Image

dhruvkb commented 1 week ago

The text is rendering correctly for me. To be extra sure, I also validated the diagram on Mermaid's Live Editor, where it also rendered correctly.

Image

AetherUnbound commented 1 week ago

Interesting!! It seems to be only rendering incorrectly for me in Firefox (including in-private browsing) 🤔 I'll have to look into this!

AetherUnbound commented 1 week ago

Here's what I'm seeing on Firefox: Image

The HTML looks different between that and Chrome too. Chrome

<g id="flowchart-ESF-15" class="node default ETL clickable">
    <rect height="78" width="230" y="-39" x="-115" ry="5" data-et="node" data-id="abc" rx="5" style="fill:#fa7def !important" class="basic label-container"></rect>
    <g transform="translate(-100, -24)" style="" class="label">
        <rect></rect>
        <foreignObject height="48" width="200">
            <div style="display: table; white-space: break-spaces; line-height: 1.5; max-width: 200px; text-align: center; width: 200px;" xmlns="http://www.w3.org/1999/xhtml">
            <span class="nodeLabel"><p>Index creation &amp; deleted media filtering</p></span></div>
        </foreignObject>
    </g>
</g>

Firefox

<g id="flowchart-ESF-15" class="node default ETL clickable">
    <rect height="30" width="30" y="-15" x="-15" ry="5" data-et="node" data-id="abc" rx="5" style="fill:#fa7def !important" class="basic label-container"></rect>
    <g transform="translate(0, 0)" style="" class="label">
        <rect></rect>
        <foreignObject height="0" width="0">
            <div xmlns="http://www.w3.org/1999/xhtml" style="display: table; white-space: break-spaces; line-height: 1.5; max-width: 200px; text-align: center; width: 200px;">
            <span class="nodeLabel"><p>Index creation &amp; deleted media filtering</p></span></div>
        </foreignObject>
    </g>
</g>
dhruvkb commented 1 week ago

I am also able to reproduce the bug on Firefox so it is indeed a problem, but it only happens on the docs site. The same diagram, copied into Mermaid's live editor, renders correctly on Firefox.