WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
254 stars 203 forks source link

Append concurrency tag to prevent issues between DAGs in staging #5155

Closed krysal closed 1 week ago

krysal commented 1 week ago

Fixes

Fixes #5128 by @stacimc

Description

This PR adds the missing STAGING_DB_CONCURRENCY_TAG to the staging data refresh DAG to prevent it from running with conflicting DAGs like the staging database restore.

It also gives the index of the wait_for_external_dag mapped tasks a friendlier name than the default numbers. Now it shows the DAG id being checked.

Testing Instructions

  1. Spin up the catalog and API stack ov just c && ov just a
  2. Run the staging_<media>_data_refresh DAGs and observe the checks for the conflicting DAGs are in place.

Screenshot 2024-11-08 at 16-38-45 staging_image_data_refresh - Grid - Airflow

Checklist

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```