Fix workflows sending messages to Slack

krysal commented 6 days ago

Fixes

Fixes #5167 by @krysal

Description

Fixes the pass of the webhook and webhook type for the action in all the workflows where it applies.

Testing Instructions

AFAIK it can only be observed during its actual execution.

Checklist

[ ] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[ ] My commit messages follow [best practices][best_practices].
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```

krysal commented 6 days ago

@WordPress/openverse-maintainers This failed to send the slack pr, but to my understanding, that is because the job still takes the version of main, and the raw logs seems to confirm it. I'll merge this to verify if that is the case.

github-actions[bot] commented 6 days ago

Latest k6 run output[^update]

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  9.0 MB/s
     data_sent......................: 837 kB  5.0 kB/s
     http_req_blocked...............: avg=18.91µs  min=1.98µs  med=3.67µs   max=7.49ms  p(90)=5.04µs  p(95)=5.48µs  
     http_req_connecting............: avg=14.12µs  min=0s      med=0s       max=7.43ms  p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=579.43ms min=42.54ms med=500.51ms max=2.26s   p(90)=1.04s   p(95)=1.15s   
       { expected_response:true }...: avg=579.43ms min=42.54ms med=500.51ms max=2.26s   p(90)=1.04s   p(95)=1.15s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=131.05µs min=41µs    med=110.61µs max=11.56ms p(90)=175.8µs p(95)=215.42µs
     http_req_sending...............: avg=20.48µs  min=6.9µs   med=18.69µs  max=4.16ms  p(90)=24.31µs p(95)=26.68µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=579.28ms min=42.4ms  med=500.37ms max=2.26s   p(90)=1.04s   p(95)=1.15s   
     http_reqs......................: 6400    38.248945/s
     iteration_duration.............: avg=3.09s    min=1.21s   med=2.6s     max=8.78s   p(90)=6.03s   p(95)=6.28s   
     iterations.....................: 1200    7.171677/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

[^update]: This comment will automatically update with new output each time k6 runs for this PR

krysal commented 6 days ago

Yeah, it worked. We're getting messages again ✅

CleanShot 2024-11-15 at 17 32 24@2x

WordPress / openverse