WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
254 stars 203 forks source link

Use healthcheck command preferred by MinIO #5170

Closed dhruvkb closed 4 days ago

dhruvkb commented 4 days ago

Description

This PR updates the healthcheck used by the MinIO container to mc which is the preferred healthcheck tool.

Testing Instructions

  1. Check out the PR.
  2. Start the catalog containers with just catalog/up.
  3. Wait for a few seconds.
  4. Run just dc ps to see the status of the Docker Compose services.
  5. The MinIO service s3 should show the status as healthy.

Checklist

[best_practices]: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines

Developer Certificate of Origin

Developer Certificate of Origin ``` Developer Certificate of Origin Version 1.1 Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129 Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. ```
dhruvkb commented 4 days ago

I was trying to understand MinIO better and was casually reading their docs and GitHub issues. There I came across a discussion that healthchecks were failing because curl couldn't be found. In that it was recommended to use mc.