WordPress / openverse

Openverse is a search engine for openly-licensed media. This monorepo includes all application code.
https://openverse.org
MIT License
254 stars 202 forks source link

Delete the Playwright Failure Test Results message after a successful test run #555

Open obulat opened 2 years ago

obulat commented 2 years ago

Problem

Currently, if your Playwright tests fail in CI, you get a very helpful message with a link to download the Artifact with stacktrace. However, it's not updated if a following test runs successfully, so the message still remains in the GitHub PR conversations, and is confusing.

Here is a link to a PR that has this problem: https://github.com/WordPress/openverse-frontend/pull/1442#issuecomment-1127306745

Description

If the check is skipped because the tests pass, we can check if the fail message was posted before, and remove it.

Alternatives

Leave it as is, we'll get used to it :)

Additional context

I don't know how difficult it would be to remove the message.

Implementation

sarayourfriend commented 2 years ago

This job is meant to do just this:

https://github.com/WordPress/openverse-frontend/blob/2036b23ee958f3a417394769aa322419be50b521/.github/workflows/ci.yml#L62-L83

It looks like it ran successfully for that PR :thinking:

https://github.com/WordPress/openverse-frontend/runs/6447397098?check_suite_focus=true

I wonder what went wrong...