Closed MichaelArestad closed 3 years ago
rejected
The Community Team uses declined
as a softer word in those situations, and I think it's worked well there.
Is there something similar for plugins?
The Add Your Plugin page will show everyone how many are in the review queue, but I think the accepted/rejected notes are sent via email.
Is that right, @Ipstenu ?
How should a user get to this page?
I think the only way to see all of your plugins is on profiles.w.org. I think it'd be good to add patterns there, for consistency.
I don't think that's easy to find, though. I like how the 5ftF design has a My Pledges
link in the navbar. That could link to the patterns on the profile, so we don't have to create duplicate pages.
Rejections are kinda saved -- everyone who has a rejected plugin, has it listed on the 'author' card:
And everyone gets an email (except for 'it's been 6 months...'). As you can see, we don't track 'why' something was rejected. Most of the time we use it for "We've rejected Bob for the same plugin 3 times. Check the emails and see if he's just not getting something or if we have a bigger issue."
In general, rejections are:
@MichaelArestad raised the interesting idea that people might like to use this as a repository for their own patterns. For example a designer or integrator might keep a library of patterns for easy access on their client sites.
We won't have any way to authenticate users from an external editor, which means they can't be completely private. But I wonder if this hints at a more nuanced set of statuses than for the plugin/theme directories. Something like:
That suggests something slightly more complex than 3 status values.
@tellyworth Exactly. I don't think we need to start with that feature as a priority, but down the road, it could be a nice enhancement.
Please consider allowing contributors to remove and transfer their patterns as well. I don't know how the plugin team handles it but for themes this process is manual.
Design for "My Patterns"
There's also more information, including an edit button, in the header of owned pattern details. The note about transferring ownership & removal is a good point, @shaunandrews where do you think that could fit in?
Instead of a single "Edit" button, perhaps we show a menu with multiple options including transferring ownership and deleting:
We can also expose this menu in the grid view of patterns:
To do here (create individual issues before tackling):
In the design, there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?
What does the "featured" dropdown do in the favorites grid?
there is one pagination, but two queries — should we show all owned patterns, and paginate favorites? or somehow paginate both? Or maybe we should create two pages after all, "my patterns" and "my favorites"?
My intention with the design was that each group would be it's own query, each with their own pagination. This is obviously not great, especially if we consider someone with more than a handful of both owned patterns and favorites. I think we should just split these up after all:
"My patterns" gets a button to create a new pattern, a filter for status, and a sort menu. "Favorites" has a category filter (maybe only show the categories that exist within the collection) and a sort menu.
What does the "featured" dropdown do in the favorites grid?
That's the "sort by" menu, which allows you to control the order of the items in the grid. In the context of "My patterns" and "Favorites" I think the options should be date (last updated), views, and favorites. The featured option doesn't really make sense on these screens.
An issue was created for the favorites page - #239. The remaining task for this issue is the management dropdown.
There should a page a user can see their submitted patterns and the status of those patterns.