WordPress / pattern-directory

The WordPress Block Pattern Directory
https://wordpress.org/patterns/
GNU General Public License v2.0
125 stars 35 forks source link

Block theme: No way to identify author if they only have 1 pattern. #670

Closed StevenDufresne closed 7 months ago

StevenDufresne commented 7 months ago

Describe the bug

In https://github.com/WordPress/pattern-directory/pull/657, we decided to hide the "More from this author" section if the author only has one pattern, the one you are viewing, because the section was empty. Most authors only have 1 pattern.

The oversight made was that in the new designs, this is the only link to the author whereas before it was on the card in the grid view as well. I'm not sure what would be best here...

@WordPress/meta-design Any thoughts on this? Should we render the section but say "the author has no more patterns?

Old New
Screenshot 2024-04-15 at 1 47 36 PM Screenshot 2024-04-15 at 1 47 27 PM
jasmussen commented 7 months ago

It sounds like, and correct me if I'm wrong, that the main issue is there's no identifying who the author is. Can we reintroduce the author-name potentially here?

Screenshot 2024-04-15 at 08 56 38

That is, to the right of the star button, show the author name? If it feels duplicative we can remove it from the "More from this author" section, when that section is present.

We can then, on the permalink for the author, show the single pattern that this author has added, so it's clear that there's just the one.

ryelle commented 7 months ago

I've tried it here, what do you think @jasmussen ? I don't think it's too duplicative because the 600px-tall preview breaks up the page, you're unlikely to notice both at once. I also made this not a link, so that it's not a repeated link on the page (a11y concern), and if the user only has this one pattern, there's no need to link to their author-archive page. The author name in the "more from …" still has the archive link if the viewer wants to see even more patterns.

Screen Shot 2024-04-15 at 10 33 08

jasmussen commented 7 months ago

I could go with the duplication, or just the author at the top. I think we can even start with one and move to the other depending on how that feels.

ryelle commented 7 months ago

Okay, if you have no strong opinion, I'll go with what I've got in that screenshot.