search

WordPress / phpunit-test-reporter

GNU General Public License v3.0
29 stars 21 forks source link

Add a custom Post_List_Table for the results post type that lacks inline edit. #101

Closed dd32 closed 2 years ago

dd32 commented 3 years ago

Fixes #100.

This is possibly the hackiest hack I've ever hacked.

This replaces the $wp_list_table global on the edit.php?post_type=result admin post listing screen with a variant that removes the quick edit/inline edit functionality for the post type.

pfefferle commented 3 years ago

LGTM!

@dd32 have you already deployed it to make.WordPress.org/hosting ? Does it work like expected?

dd32 commented 3 years ago

LGTM!

dd32 have you already deployed it to make.WordPress.org/hosting ? Does it work like expected?

I haven't, I submitted this PR as I was signing off for my Friday evening, and I'm AFK for the next week, sooo figured it best to wait :) Either someone else on the meta team can deploy, or I will when I'm back. It's not super-dooper urgent, unless it's breaking the PHPUnit test reporters (which it doesn't look like?)

It does however work for me with production data. It does result in double posts query, but that's better than a fatal error. I did try to abort the query, but changing the global WP_Query from a hook within WP_Query doesn't play nice :)

pfefferle commented 2 years ago

hey @dd32 any updates on this PR? where you able to release this to make.wordpress.org?

dd32 commented 2 years ago

Looks to have been working, added it in https://github.com/WordPress/wordpress.org/commit/78ac9358125691b72f155432dc29c46ef0f43d2f (and then fixed it in https://github.com/WordPress/wordpress.org/commit/a758102988587081f0c260f6b41346f3630ddcd5 as I merged it incorrectly...)