Check PHP8 compatibility

WordPress / phpunit-test-reporter

GNU General Public License v3.0

29 stars 21 forks source link

Check PHP8 compatibility #82

Open pfefferle opened 4 years ago

pfefferle commented 4 years ago

https://wordpress.slack.com/archives/C3D6T7F8Q/p1593596189094100

getsource commented 3 years ago

Doing this step by step.

Step one:

I tested the plugin in PHP8 and it seems to work as expected so far.

Get reporter's automated tests running with PHP8
Check to see that test runner works as expected with PHP8: https://github.com/WordPress/phpunit-test-runner/issues/121

desrosj commented 3 years ago

First 👏 and thanks to Seravo for adding PHP8 testing. ❤️

I'm am trying to figure out why the tests fail for them but not Core on Travis, and wondering if something in here is causing the failure.

ottok commented 3 years ago

If it helps debugging, here is the same commit tested with both PHP 7.4 (pass) and PHP 8.0 (failure):

https://make.wordpress.org/hosting/test-results/r49470/seravobot-r49470/

The PHP 8.0 was the latter run, so it's results remain on the result page.

Since the result page does not show any detailed log, I have attached them manually. php80.txt php74.txt

getsource commented 3 years ago

There might be more problems, but I think the main issue is that the test runner is using PHPUnit 5.6.x: https://github.com/WordPress/phpunit-test-runner/issues/121#issuecomment-717169367

ottok commented 3 years ago

If somebody makes a PR or test branch on this topic, I am happy to run the test runner based on code from an alternative branch to verify if the proposed changes fix the issue.