search

WordPress / playground-tools

GNU General Public License v2.0
142 stars 41 forks source link

Playground Block: Simplify running Core and Gutenberg PRs #264

Open dmsnell opened 6 months ago

dmsnell commented 6 months ago

It would be great if inside the Playground Block one could have an auto-completer search Gutenberg and Core PRs to apply to the Playground.

As often as I share a Playground Block, I'm usually doing it for development purposes to show how code in a patch, or a combined patch between the two repos, can be written and possible.

This currently requires creating Blueprint steps, remembering to run through a Github proxy, remembering to use the right domain (since CORS issues relate to the blog on which the block appears, no longer to playground.wordpress.net), and remember how to merge that with any other potential Blueprints.

If we had a selector in the Block Controls that could automatically fill in these details and merge them with whatever Blueprints are chosen, it would make it that much easier to demonstrate test setups. It would also make it more convenient to try out different sets of Blueprints with various Core and Gutenberg patches running, whereas we wouldn't have to edit every single one of those Blueprints.

adamziel commented 6 months ago

Boot protocol will greatly simplify loading WordPress core PRs, and from there this fill be about UX improvements in the block.

dmsnell commented 6 months ago

this fill be about UX improvements in the block.

This issue specifically is all about the UX of the block, however it happens technically.

sirreal commented 3 months ago

I see the following as part of related work in https://github.com/WordPress/wordpress-playground/issues/1398.

Replace the entire WordPress PR previewer Blueprint with a single artifact URL

I would be very happy to have that functionality! It would greatly simplify testing some WordPress Core changes.

adamziel commented 3 months ago

@sirreal we're there already! See the WordPress PR previewer code:

https://github.com/WordPress/wordpress-playground/blob/56502a4027c3585d3c13c95f21300fd3ddd3589a/packages/playground/website/public/wordpress.html#L216-L225

dmsnell commented 3 months ago

@adamziel last time I tried this page had a different flow than the Playground home page and the Query API didn't work the same, nor did Blueprints. I would love it if that page were replaced by a &wordpress-pr=12345 and/or &gutenberg-pr=12345 query arg.

As stated above:

This currently requires creating Blueprint steps, remembering to run through a Github proxy, remembering to use the right domain (since CORS issues relate to the blog on which the block appears, no longer to playground.wordpress.net), and remember how to merge that with any other potential Blueprints.

Frequently my situation is wanting to combine a Core and/or Gutenberg patch with a specific plugin or plugins and then also potentially run my own Blueprint steps. Using the wordpress.html page doesn't indicate how that's possible, apart from modifying the escaped and encoded Blueprints it generates after navigating back to the Playground.