WordPress / playground-tools

GNU General Public License v2.0
127 stars 38 forks source link

Playground block: Update CodeMirror deps for a11y fix #317

Closed brandonpayton closed 3 days ago

brandonpayton commented 1 week ago

What?

This PR updates CodeMirror dependencies to include a recent accessibility-related autocomplete fix: https://discuss.codemirror.net/t/avoiding-aria-autocomplete-list-when-no-autocompletion-providers/8313/2

Why?

Fixes #289 - "Playground block: A11Y: Use correct ARIA specification for autocomplete"

Implementation

This PR updates npm dependencies for CodeMirror. The Playground block appears to work well with the update.

The interactive-code-block doesn't render well in the editor either before or after these updates. (Is it still in use anywhere, and if not, can we delete it? cc @adamziel)

Testing Instructions