Playground block: Mark code editor input field as readonly when it is read only

WordPress / playground-tools

GNU General Public License v2.0

136 stars 38 forks source link

Playground block: Mark code editor input field as readonly when it is read only #331

Closed brandonpayton closed 1 week ago

brandonpayton commented 1 month ago

From @alexstine here:

For the read-only files, awesome that the button communicates that but the input field does not. Think you can open an upstream PR to get aria-readonly or HTML5 readonly support?

brandonpayton commented 1 month ago

@alexstine this turned out to be fairly straightforward as the inconsistency was due to a bug in the Playground block itself. No upstream work appears to be necessary. This should be fixed by #337 which is included in the latest (v0.2.12) release. At this moment, the Learn site still needs updated to that version though.

adamziel commented 2 weeks ago

@brandonpayton is this one now resolved, since #337 is merged?

brandonpayton commented 1 week ago

This was tested by someone with a11y expertise and can now be marked as resolved.