WordPress / playground-tools

GNU General Public License v2.0
140 stars 41 forks source link

Navigation: Links to posts / pages not working #349

Closed asathoor closed 4 weeks ago

asathoor commented 2 months ago

When I add pages and posts to the navigation menus the links are not clickable. It seems that the URL is not correctly formatted. I figured out this workaround:

brandonpayton commented 2 months ago

Hi @asathoor, so far I have been unable to reproduce this issue. If I add a page to a nav menu, it has been possible to click the link and have navigation happen within Playground.

Would you be up for sharing a video or specific steps to help reproduce this issue?

asathoor commented 2 months ago

Hi Brandon, perhaps it was just a temporary error, or something caused by plugins. Now things work again. Thank you for looking into the problem :-)

brandonpayton commented 2 months ago

Thank you for reporting and retesting this, @asathoor. :-)

asathoor commented 2 months ago

Hi again, Well, I've found out that the problem is still there. If I create a menu it will work, as long as the present instance of WP runs. However, when I reload the project from a file saved on my computer the menu does not work any more. It must have something to do with the URL strings, I guess. If the URL changes after the reload from the local files, then the menu might not work. So the menus must be remade after a relaunch. Here are the files from my repo on Github / best regards, Per

asathoor commented 2 months ago

I only have the mentioned problem with the navigation menu on the link version - when I use Playground with wp-now everything works like a charm.

adamziel commented 1 month ago

@asathoor could this be the same problem as https://github.com/WordPress/wordpress-playground/issues/1780 ?

asathoor commented 1 month ago

It looks very similar to my experience.

asathoor commented 1 month ago

I looks very similar to my problem.

Den ons. 25. sep. 2024 kl. 14.26 skrev Adam Zieliński < @.***>:

@asathoor https://github.com/asathoor could this be the same problem as WordPress/wordpress-playground#1780 https://github.com/WordPress/wordpress-playground/issues/1780 ?

— Reply to this email directly, view it on GitHub https://github.com/WordPress/playground-tools/issues/349#issuecomment-2373942419, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOU3PZTYZXIBOJVN6JTXJTZYKTV5AVCNFSM6AAAAABNAI4GX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTHE2DENBRHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Per Thykjær Jensen tlf. +45 4119 6624 web: http://www.multimusen.dk/ blog: http://multimusen.blogspot.com

bgrgicak commented 4 weeks ago

@asathoor I tried testing it and this is what I got. Could you please confirm that my testing matches what you experienced?

We made some changes to how scopes are defined in the new UI and it seems to work for me now as long as I don't delete the site. If you create a new site and point it to the same directory it will break because the scope changed.

If that's your experience, this is the same issue as https://github.com/WordPress/wordpress-playground/issues/1780.

This is what I did:

asathoor commented 4 weeks ago

Yes, it works! Now things seem to work as supposed. Thank you :-)

Den tirs. 8. okt. 2024 kl. 11.32 skrev Bero @.***>:

@asathoor https://github.com/asathoor I tried testing it and this is what I got. Could you please confirm that my testing matches what you experienced?

We made some changes to how scopes are defined in the new UI and it seems to work for me now as long as I don't delete the site. If you create a new site and point it to the same directory it will break because the scope changed.

If that's your experience, this is the same issue as WordPress/wordpress-playground#1780 https://github.com/WordPress/wordpress-playground/issues/1780.

This is what I did:

  • create a site using local storage
  • add a menu link to a page (Sample page)
  • Confirm the link works and it includes the scope
  • Reload Playground
  • The link still works

— Reply to this email directly, view it on GitHub https://github.com/WordPress/playground-tools/issues/349#issuecomment-2399344815, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOU3P2JLMCZX35XOI4F7XLZ2ORDJAVCNFSM6AAAAABNAI4GX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGM2DIOBRGU . You are receiving this because you were mentioned.Message ID: @.***>

-- Per Thykjær Jensen tlf. +45 4119 6624 web: http://www.multimusen.dk/ blog: http://multimusen.blogspot.com

bgrgicak commented 4 weeks ago

Thank you for checking! I will close this issue and keep https://github.com/WordPress/wordpress-playground/issues/1780 to track support on rewriting scoped URLs.