Closed ernilambar closed 6 months ago
Code is updated as per the comments. New commands will be:
wp plugin list-checks
wp plugin list-check-categories
Behat tests implementation for new commands is remaining.
@swissspidy Is it possible to run behat tests in local environment? Or is it implemented now in GitHub actions only?
Use composer behat
to run the Behat tests.
You may need to run composer prepare-behat-tests
once first to create the test database
PR ready for review.
PR has been update as per the review comments.
Note:
@SuppressWarnings(PHPMD.ExcessiveClassComplexity)
in Plugin_Check_Command
.get_list_check_categories_options()
and get_list_checks_options()
methods are similar now. But there is some room for enhancements for those listing commands. When we implement those, methods would be different. In the follow-up PR, it's essential to update the documentation to reflect the changes made by this pull request. Specifically, we removed the Abstract_Check_Runner::register_checks()
method. cc. @felixarntz
The affected documentation files that need updating are:
PR updated as per the comments. Fixed spacing issues and improved function docs.
Fixes #303
Command:
wp plugin list-check-categories
Output:![Screen Shot 2023-12-14 at 4 01 54 PM](https://github.com/WordPress/plugin-check/assets/2098823/19a277de-55b3-446a-8ae1-9bc045ee5244)
Command:
wp plugin list-checks
Output:![Screen Shot 2023-12-14 at 4 01 39 PM](https://github.com/WordPress/plugin-check/assets/2098823/51fa93c6-7260-49c6-9e9e-44aa8db438c7)