search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
242 stars 49 forks source link

Remove default select option from dropdown #344

Closed ernilambar closed 9 months ago

ernilambar commented 9 months ago

Fixes https://github.com/WordPress/plugin-check/issues/343

mukeshpanchal27 commented 9 months ago

Thanks @ernilambar for the PR. I like the idea to remove default empty selection. If we there is no plugin then it will show No plugins available. message.

I value the input from @felixarntz and @joemcgill on this matter.

felixarntz commented 9 months ago

Hmm, I'm not sure about this. The only benefit I could see here is if a site only has a single plugin and that's what you want to test. But otherwise I would find it an arbitrary choice to have the alphabetically first plugin pre-selected, so from that perspective I prefer the neutral default we have now.

How about this?

I think that would be a good compromise that would address both concerns.

I don't feel strongly about it though, curious to hear other perspectives.

mukeshpanchal27 commented 9 months ago

How about this?

  • If there's one plugin, we only put that plugin there and have it pre-selected.
  • Otherwise, things remain as they are now.

I personally like these suggestion.

ernilambar commented 9 months ago

PR updated as per the comment.