search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
198 stars 39 forks source link

Require Node v20 #353

Closed swissspidy closed 6 months ago

swissspidy commented 6 months ago

See https://make.wordpress.org/core/2023/12/20/updating-wordpress-to-use-more-modern-versions-of-node-js-npm-2/

ernilambar commented 6 months ago

I checked this PR in my local setup. npm install and our other node scripts are also working as expected.

ernilambar commented 6 months ago

@mukeshpanchal27 This error seems to appear in trunk also. But composer run-script phpstan is working as expected.

swissspidy commented 6 months ago

PHPStan has nothing to do with Node.

This particular error is ignored in PHPStan FWIW, https://github.com/WordPress/plugin-check/blob/72f3eb321cf1cd05c234367443da1ccdfd90bcd5/phpstan.neon.dist#L17-L23

So you should not encounter it. I don't get any errors on trunk at least.

But again, not related to do this PR.