Update Code Obfuscation Check to display multiple errors

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.

https://wordpress.org/plugins/plugin-check/

GNU General Public License v2.0

242 stars 49 forks source link

Update Code Obfuscation Check to display multiple errors #366

Closed ernilambar closed 2 months ago

ernilambar commented 9 months ago

Fixes https://github.com/WordPress/plugin-check/issues/363

Added new static methods in Abstract_File_Check
- files_preg_match() - Returns multiple files unlike file_preg_match()
- Similarly files_str_contains
Updated methods in Code_Obfuscation_Check to handle array of files instead of a single file
files_preg_match() returns array of file and match. This data could be useful in the future enhancements. Eg:

CLI output:

github-actions[bot] commented 2 months ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ernilambar commented 2 months ago

May be this PR should be rewritten following the approach used in Detect localhost/127.0.0.1 code in multiple files

ernilambar commented 2 months ago

Closing in favor of https://github.com/WordPress/plugin-check/pull/532