search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
198 stars 39 forks source link

Change logic for finding plugin slug in CLI #367

Closed ernilambar closed 6 months ago

ernilambar commented 6 months ago

Fixes https://github.com/WordPress/plugin-check/issues/364

ernilambar commented 6 months ago

PR updated as per the review comments.

ernilambar commented 6 months ago

@mukeshpanchal27 After last commit, Behat test (PHP 8.0 WP Latest) is failing. Any idea?

swissspidy commented 6 months ago

Does it pass locally for you? There might be some error/notice happening

ernilambar commented 6 months ago

Does it pass locally for you? There might be some error/notice happening

I could not make it run Behat tests locally. Some database error occurs and tests fails even before starting. So I usually check those in GitHub Actions.

mukeshpanchal27 commented 6 months ago

@mukeshpanchal27 After last commit, Behat test (PHP 8.0 WP Latest) is failing. Any idea?

The nikic/php-parser get updated from 4.18.0 to 5.0.0 in past few hours that may be issue as they update things related to PHP versions. cc. @swissspidy

swissspidy commented 6 months ago

@mukeshpanchal27 After last commit, Behat test (PHP 8.0 WP Latest) is failing. Any idea?

The nikic/php-parser get updated from 4.18.0 to 5.0.0 in past few hours that may be issue as they update things related to PHP versions. cc. @swissspidy

This project dos not use PHP-Parser, nor do any of the dependencies.

I could not make it run Behat tests locally. Some database error occurs and tests fails even before starting. So I usually check those in GitHub Actions.

Have you tried running composer prepare-behat-tests first to set up the database? Or run WP_CLI_TEST_DBTYPE=sqlite composer behat to test without MySQL.

From what I can see in the logs, this failure started already at https://github.com/WordPress/plugin-check/actions/runs/7443210203 (though it worked fine on the PR branch itself)

So it's not isolated to this PR.

Unfortunately I'm unable to reproduce this locally right now, so let's deal with this in a separate PR to debug in more detail. No blocker for this PR.

mukeshpanchal27 commented 6 months ago

Have you tried running composer prepare-behat-tests first to set up the database? Or run WP_CLI_TEST_DBTYPE=sqlite composer behat to test without MySQL.

I've tested it locally, and it seems to be working fine for me as well. Not entirely sure why the issue persists. I've opened a dedicated issue to track and investigate that. Thank you!