search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
198 stars 39 forks source link

PHPUnit shows `Warning` message "The configuration file did not pass validation!" #369

Closed mukeshpanchal27 closed 6 months ago

mukeshpanchal27 commented 6 months ago

I observed some warning messages related to unit tests. Starting from PHP 7.1, we've been encountering these messages. You can find the details here: https://github.com/WordPress/plugin-check/actions/runs/7281778666.

Warning - The configuration file did not pass validation!
The following problems have been detected:

Line 9:
- Element 'coverage': This element is not expected.

Test results may not be as expected.

And another is:

Warning - The configuration file did not pass validation!
The following problems have been detected:

Line 25:
- Element 'filter': This element is not expected.

Test results may not be as expected.
mukeshpanchal27 commented 6 months ago

The phpunit.xml.dist and tests/phpunit/multisite.xml were updated in #321 and added coverage and filter tags.

cc. @eclarke1 @felixarntz @swissspidy @joemcgill

swissspidy commented 6 months ago

Since we have to run tests with multiple PHPUnit versions I don't think it's possible to have a single config file format that works for all versions without warnings. So this is expected IMHO and not a big deal. Just warnings.

felixarntz commented 6 months ago

+1 to @swissspidy's feedback, I don't think this is crucial enough to go through the hassle of multiple config files. I would suggest we close this as not planned.