WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
242 stars 49 forks source link

Implement field names validation in check command #378

Closed ernilambar closed 8 months ago

ernilambar commented 8 months ago

Fixes https://github.com/WordPress/plugin-check/issues/360

ernilambar commented 8 months ago

cc: @swissspidy @felixarntz @mukeshpanchal27

swissspidy commented 8 months ago

Hmm not really a fan of duplicating logic the formatter already gives us for free and adding more complexity. The current output is maybe not super optimal because we're using it in a loop with some heading before it, but I don't think it's a big deal.

felixarntz commented 8 months ago

@ernilambar +1 to what @swissspidy says. I personally am unsure this is important to validate. If we want to add validation for arguments, there would probably be a more flexible and useful way than only checking for whether any unsupported parameters are passed. I think it works well enough at this point.