WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
240 stars 46 forks source link

Enhancement: Add option to exclude files from checking #388

Closed mukeshpanchal27 closed 3 months ago

mukeshpanchal27 commented 8 months ago

Feature Description

In #206, we introduced the ability to run checks for specific categories in both WP Admin and WP-CLI. However, one important aspect was missing - the ability to exclude specific files from all checks. This proposed enhancement aims to provide users with the flexibility to exclude certain files they don't wish to update, enhancing the overall usability, especially in the CLI.

Proposed Implementation:

For WP-CLI:

For WP Admin:

Designs:

For WP-CLI:

wp plugin check --exclude-files=file1,file2,file3

For WP Admin: WP Admin Design

Benefits:

mukeshpanchal27 commented 8 months ago

cc. @felixarntz @joemcgill @eclarke1

ernilambar commented 8 months ago

I think we should keep that textarea (and another textarea for excluding directories which is not implemented yet) should be display under a toggler. Otherwise lots of screen area would be occupied by form only. Eg:

Screenshot 2024-01-12 at 10 54 12 AM

mukeshpanchal27 commented 8 months ago

I think we should keep that textarea (and another textarea for excluding directories which is not implemented yet) should be display under a toggler. Otherwise lots of screen area would be occupied by form only. Eg:

+1. I would like to get other folks( Felix, @swissspidy ) feedback on this before move forward.

felixarntz commented 8 months ago

@mukeshpanchal27 I would prefer if we only implemented this for WP-CLI for now. For CLI commands, having a lot of flexibility is good, but for UI it's a different beast - last but not least we should keep in mind "Decisions not options".

I'm not saying we definitely shouldn't implement this in the UI, but it's a lot more of a detail and I think it would need more careful design consideration than just adding another checkbox. The UI we have right now is super rudimentary, and I don't think adding more and more on top of it is a good idea. I'd prefer to stick with the essentials based on where we are now.

swissspidy commented 3 months ago

Closing for now as there is the WP-CLI integration.