search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
195 stars 39 forks source link

Make parser warnings more clear #395

Closed ernilambar closed 5 months ago

ernilambar commented 5 months ago

Fixes https://github.com/WordPress/plugin-check/issues/394

ernilambar commented 5 months ago

https://meta.trac.wordpress.org/ticket/7412 This will add more parser warnings. It'd be better if we incorporate those changes here also.

ernilambar commented 5 months ago

PR is updated and new warnings are also incorporated.

cc: @swissspidy @felixarntz @mukeshpanchal27

ernilambar commented 5 months ago
  • Add unit test that ignore all these warnings. I think we can archive it using add_filter( 'wp_plugin_check_ignored_readme_warnings', '__return_empty_array' );.

Its the opposite. Sending empty array in that filter will disable ignoring and all warnings are displayed. We already have test_filter_wp_plugin_check_ignored_readme_warnings_will_return_no_error to test same functionality. Do we need another similar one?