Detect localhost/127.0.0.1 code in multiple files

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.

https://wordpress.org/plugins/plugin-check/

GNU General Public License v2.0

195 stars 39 forks source link

Detect localhost/127.0.0.1 code in multiple files #399

Open ernilambar opened 5 months ago

ernilambar commented 5 months ago

Fixes https://github.com/WordPress/plugin-check/issues/362

Adds method files_preg_match in Abstract_File_Check to return multiple results matched with given regex.
Update Localhost_Check to handle array of results
Update Localhost_Check_Tests accordingly

ernilambar commented 5 months ago

cc: @swissspidy @felixarntz @mukeshpanchal27

swissspidy commented 5 months ago

Let's discuss the right approach on the issue first. This applies to other checks as well.

frantorres commented 1 week ago

Thanks for this change, I think that for this check it would be really useful to also give users the line + column where that happens (as well as showing more than one case for file). I mentioned this on #362 .

Also, I can suggest to add other common "localhost" cases like:

https?:\/\/(?:[^\s\/]*\.)++local(?:host)? (this covers domains ending in .local and .localhost, for example: docker.local)

ernilambar commented 1 week ago

PR has been updated based on feedback.

github-actions[bot] commented 12 hours ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.