search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
195 stars 39 forks source link

Trunk version not available on Subversion #432

Open ernilambar opened 4 months ago

ernilambar commented 4 months ago

Ref: https://translate.wordpress.org/projects/wp-plugins/plugin-check/

Why strings are not showing in Development? Any idea?

swissspidy commented 4 months ago

Because the development version, i.e. trunk, currently only contains the readme and no code.

cc @bordoni

bordoni commented 4 months ago

Ohh I see, good point. But the code under trunk would be the same as the Stable Tag:. I am not sure how we would benefit from having that.

I know there are other benefits from having trunk.

ernilambar commented 4 months ago

I noticed this issue when translating. I use this plugin https://wordpress.org/plugins/force-update-translations/ But due to some issue, this plugin only downloads strings from Development.

swissspidy commented 3 months ago

In theory you could actually put a beta or release candidate in trunk but I don't think we need that.

It's pretty normal for trunk + latest tag to be identical. It would also make it easier to use https://downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

Not using trunk is more confusing than useful.

dd32 commented 3 months ago

It's pretty normal for trunk + latest tag to be identical.

Yeah; Either have trunk+tag the same, or have trunk actually have the code from GitHub trunk sync'd daily/every push.

If the deploy workflow is used; it should set trunk contents to that of the stable release. I've just fixed the secrets/svn credentials for this repo.

It would also make it easier to use https://downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

for that, use https://downloads.wordpress.org/plugin/plugin-check.latest-stable.zip

swissspidy commented 3 months ago

It's pretty normal for trunk + latest tag to be identical.

Yeah; Either have trunk+tag the same, or have trunk actually have the code from GitHub trunk sync'd daily/every push.

If the deploy workflow is used; it should set trunk contents to that of the stable release.

Correct. And we intended to use that workflow. But the initial 1.0.0 and 1.0.1 were pushed manually because the action timed out due to the many new files being added.

So right now the empty trunk folder prevents us from using this workflow.

So my tl;dr is: let's just fix this please to make our lives easier :)

I've just fixed the secrets/svn credentials for this repo.

Can you clarify this? The GitHub secrets in this repo should have been correct already (using the performanceteam user). What did you change these to now?

It would also make it easier to use downloads.wordpress.org/plugin/plugin-check.zip for downloading the latest release.

for that, use downloads.wordpress.org/plugin/plugin-check.latest-stable.zip

TIL! Thanks.