New Check License for Readme and Plugin Header

[davidperezgar]

With this new check solves the issue #436 with this checks:

• Verify that Readme has GPL license.
• Verify that Plugin header has GPL license.
• Verify that is the same license between two files.

Fixes #436

[davidperezgar]

I've updated my tests for the new check. Please check @Pacomarchante and @frantorres

[davidperezgar]

Hey, the testing is not working because this reason:ç

[2024-06-22T15:14:50.797Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 1674s.', code='throttled')}

[swissspidy]

This is expected at the moment because PRs from forks don't have access to repository secrets like the codecov token. It can be simply ignored. If you create a PR from a branch directly in this repo, this won't happen.

[swissspidy]

Would be great to add new tests for this change :-)

[davidperezgar]

Yeah, This PR I've made before I have acces to the repo. But it's blocking the merge.

[davidperezgar]

It has the necessary test for different license. How can we solve the merging problem?

[swissspidy]

I just see a lot of code being added but not any new tests. Not a huge deal, but I would have expected more test coverage there.

The failing test does not block anything. Merging is blocked because 2 reviewers requested changes and there are 0 approvals. You can dismiss stale reviews but you still need approvals. Once a PR is approved, it can be merged.

[davidperezgar]

Ok!

[frantorres]

Looks good. Just a detail. The new check was named different_license and there are already other check with the name stable_tag_mismatch, I propose to change it to license_mismatch to follow the convention.

[davidperezgar]

Done!

[davidperezgar]

Changes asked by @mukeshpanchal27 done!