search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
268 stars 53 forks source link

The "Plugin URI" header in the plugin file is not valid... except it is #771

Open dartiss opened 3 weeks ago

dartiss commented 3 weeks ago

My plugin Code Embed (see https://wordpress.org/plugins/simple-embed-code/) has the following URI in the header...

 * Plugin URI:        https://wordpress.org/plugins/simple-embed-code/

However, plugin check is reporting it as invalid.

Code: plugin_header_invalid_plugin_uri_domain Message: The "Plugin URI" header in the plugin file is not valid.

swissspidy commented 3 weeks ago

AFAIK the link should point to your website / the plugin‘s landing page, not just the plugin‘s listing in the plugin directory.

dartiss commented 3 weeks ago

The URL is valid though. If the real reason for the failure is because it's a wp.org domain, maybe it should specifically indicate that?

ernilambar commented 2 weeks ago

Yes, we could improve the message. Currently error is triggered for domain wordpress.org and example.com.

ernilambar commented 2 weeks ago

Message is coming from here https://github.com/WordPress/plugin-check/blob/trunk/includes/Checker/Checks/Plugin_Repo/Plugin_Header_Fields_Check.php#L116 Want to submit a PR?