search

WordPress / plugin-check

A repository for the new Plugin Check plugin from the WordPress Performance and Plugins Team.
https://wordpress.org/plugins/plugin-check/
GNU General Public License v2.0
266 stars 53 forks source link

Force slug in wp cli command to ensure that it get's the correct one by default #780

Open davidperezgar opened 1 week ago

davidperezgar commented 1 week ago

Fixes #774

github-actions[bot] commented 1 week ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: hirasso <nonverbla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

ernilambar commented 1 week ago

@davidperezgar https://github.com/WordPress/plugin-check/issues/774 This issue is about incorrect plugin slug calculation when checked like /wp-content/plugins/my-plugin/my-plugin. I am not getting how this solves the mentioned issue. Am I missing something?

ernilambar commented 1 week ago

Removing from 1.3 milestone. We can push this for 1.4 after detailed discussion.

davidperezgar commented 1 week ago

My proposal is to calculate the default slug before launching the checks. If slug is empty, then it should calc the slug.