WordPress / props-bot-action

A GitHub Action for compiling a list of contributor props.
Other
13 stars 5 forks source link

Always create new comment for visibility #125

Closed ellatrix closed 3 weeks ago

ellatrix commented 4 months ago

What?

Always create a new comment at the bottom of the PR.

Why?

To increase visibility of the comment, and make it harder to miss.

The problem with editor the comment is that is maintains the same position on a PR.

How?

Instead of editing the previous comment, delete it. Then always add a fresh comment, which will appear at the bottom.

Testing Instructions

You can see a test run on https://github.com/WordPress/gutenberg/pull/62756: https://github.com/WordPress/gutenberg/actions/runs/9616861940/job/26528178346?pr=62756

desrosj commented 3 weeks ago

@ellatrix and I chatted about this on a few occasions. The intention here was to improve maintainer workflows and avoid forgetting to add props when merging. But this approach would result in many more notifications, especially on PRs with high levels of activity.

Going to close this out.